bespoken/virtual-device-sdk

Can't use virtual device SDK without https

Closed this issue · 2 comments

dmarvp commented

Description:

The current implementation works only when virtual device is in an https environment. The port is hardcoded to 443:

virtual-device-sdk/src/VirtualDevice.ts

Line 117 in 7d720fc

port: 443,

We need to change it so that it also works with custom urls that don't use HTTPS.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Have an instance of virtual device running at http://localhost:3000
  2. set the env variable VIRTUAL_DEVICE_BASE_URL to that url
  3. do a request (from bst)

Expected behavior

The response should be returned correctly.

Actual behavior

We get an error response.

Additional context

We need to remove the hardcoded 443 port on VirtualDevice.ts and probably change the library used from https to http.

Also update bst with a new version once this is done.

MKen-li commented

Marked as verified
Build bespoken-tools@2.1.1