betodealmeida/gsheets-db-api

Add support for granularity functions

betodealmeida opened this issue 6 years ago · 2 comments

betodealmeida commented 6 years ago

We need to add proper support for granularity functions, so it can be used in Superset. The current PR (apache/superset#5915) is incorrect.

betodealmeida commented 6 years ago

Here's how Presto does it: https://github.com/apache/incubator-superset/blob/84ae884c5ddffb65378654fe17afd5526cae039c/superset/db_engine_specs.py#L670-L686

betodealmeida commented 6 years ago

Implemented in 4cbcff2.