Search is broken for more than 1 letter
betsegaw opened this issue · 1 comments
betsegaw commented
Search does not match anything after the first letter (see screenshots for example) starting from commit 64d6a32
For one letter you get:
When you add 2 you get:
@mjrichmond I hadn't noticed that commit. I am reverting it for the following two reasons,
- It is more useful to have score based on overall distribution of letters.(eg. for a search of "moo", "mxxoxxo" should score higher than "mxxxxxxoxxxxxxxxo")
- The original one has been "overused" by me so a bunch of corner cases were discovered and accounted for. Even though there are tests bundled along with the old one, there is not enough coverage to verify the new one thoroughly (as shown by the bug). I should have invested a little bit more time in creating more tests but I had gotten lazy lol :)