bevry/dorothy

Bug: Dorothy sets CC to ''

Closed this issue · 1 comments

edmcman commented

On my machine, dorothy is setting CC and related build variables to an empty string. This causes some tools to do silly things like:

   -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -fPIC -DPACKAGE=jep -DUSE_DEALLOC=1 -DJEP_NUMPY_ENABLED=0 -DVERSION=\"4.2.0\" -DPYTHON_LDLIBRARY=\"libpython3.10.so\" -I/usr/lib/jvm/temurin-17-jdk-amd64/include -I/usr/lib/jvm/temurin-17-jdk-amd64/include/linux -Isrc/main/c/Include -Ibuild/include -I/home/ed/Ghidra/venv/include -I/usr/include/python3.10 -c src/main/c/Jep/convert_j2p.c -o build/temp.linux-x86_64-cpython-310/src/main/c/Jep/convert_j2p.o
      error: command '-Wno-unused-result' failed: No such file or directory
      [end of output]

These variables should probably be unset by default instead...

balupton commented

Here's the culprit:

dorothy/commands/setup-environment-commands

Line 108 in 2da8d15

export LDFLAGS='' CPPFLAGS='' CC='' CXX='' # do wipe as don't have duplicate prevention

I'll change it to only export it when we have a value for it.

  • ❤️1