`Error occurred while downloading: 2` when asking to redownload by `springname`
Jazcash opened this issue · 2 comments
Jazcash commented
p2004a commented
Tested and I can reproduce it.
There are 2 issues:
-
pr-downloader here does a resolution from game, to tag, and then downloads tags, visible from log:
[Debug] /home/p2004a/Workspace/BAR/spring/tools/pr-downloader/src/Downloader/Download.cpp:34:addMirror():byar:test [Debug] /home/p2004a/Workspace/BAR/spring/tools/pr-downloader/src/Downloader/Download.cpp:34:addMirror():byar:git:ee934c8b60943f321d5874ebe23d883e4f
So it attempts to download game twice, because the game is referenced by 2 tags (entirely normal)
-
It reports error on condition when game is already downloaded. Probably because
dl->state != IDownload::STATE_FINISHED
fails, because one of the downloader didn't properly set the finished status in this corner case.
p2004a commented
This error happens only when downloading by the springname
and not by the rapid tag. When downloading by rapid tag, it doesn't error out when stuff is downloaded.