inconsistent data format in BBcAsset (asset_file_digest)
Closed this issue · 1 comments
quvox commented
In the packing method of BBcAsset (bbclib_asset.py), the "asset_file_digest" is packed with length value for data packing. However, for calculating "asset_id", asset_file_digest is packed without length value. This is confusing and inconsistent in terms of format design (it may be just a kind of bug). Even though it is not fatal issue, this should be fixed.
"asset_id" is just an identifier. So, adding length field in packing for calculation of asset_id would be OK.
In addition, asset_file_digest is truncated by id_length in some cases in bbclib_asset.py. It is also inappropriate and should be fixed.