Incorrect default value shown for flush interval messages
sterobin opened this issue · 2 comments
@ajaypratap003 @anukritijha Pinging you, but feel free to re-assign as needed. Not sure if you prefer an issue here or a JIRA. Let me know. We noticed this while reviewing this docs PR for topic properties.
The default value for both flush.messages
and flush.ms
topic properties is the same numeric value of 9223372036854775807
according to the kafka properties, as shown in our product API response today:
Default values in API response:
{
"key": "flush.messages",
"value": "9223372036854775807"
},
{
"key": "flush.ms",
"value": "9223372036854775807"
}
This is correct because for flush.messages
, that number is the number of messages, whereas for flush.ms
, that number is the number of milliseconds.
However, in the UI today, it shows both default values as time intervals, as shown below:
Default values in UI
To fix this, the "Flush interval messages" value in the UI should be simply 9223372036854775807
or 9223372036854775807 messages
.
In the code, this looks correct in constant.ts, but seems like it might be off in utils.ts, which associates messages with milliseconds.
I'm happy to submit a PR to fix this myself, but I'm not sure what exactly needs to be fixed, where, and how. Thoughts?
Thanks!
Oh great! Thanks @rkpattnaik780 ! Closing.