bfabiszewski/ulogger-android

Automation idea: `start new logger if synchronized` command

Quppa opened this issue · 4 comments

Quppa commented

Context: I use automation to start a new logger each morning for 24/7 tracking (I acknowledge this isn't the primary purpose of the app). Recently I lost connectivity to my server for ~36 hours and lost a day's worth of data when the automated task was executed.

Trying to create a new track via the UI when the current track isn't synchronised displays notsync_warning (Current track contains not synchronized positions. Setting new track will delete all this data.), but the start new logger command (quite reasonably) bypasses this check.

Supporting multiple tracks I presume is beyond the scope of the client app.

In order to avoid data loss in the above scenario, would you consider supporting a command called something like start new logger if synchronized, which only calls newTrack if needsSync is false?

I'm happy to prepare a PR with the change.

bfabiszewski commented

Sorry for late answer!
I've never really used the automation, but your point seems reasonable.
Please go on with the PR. I'll be glad to merge it.
Thanks!

  • 👍2
glynnt commented

Thanks for the great app & ideas.

I added 2 options

  1. whether allow new track when not yet synchroized
  2. whether reuse the existing track when start new track but existing track not yet synchroized
    I have been using the modified version on my phone for days, but the translation for the new options not yet completed.

If you have not started the work yet & don't mind I can new PR after I complete the translation (may need to use google translate).
If the work already started, I would happy to use your version.

Thanks again.

Quppa commented

Thanks @glynnt - I didn't get around to doing this, so please go ahead.

bfabiszewski commented

@glynnt Sorry, I did not have time to look at it earlier.
Anyway I think I will go for a simpler option. Just add support for a new parameter (extra).
Your way would be more comfortable but I don't want to go into changing ui and adding translations, as automated translations are often tricky. Also prefer to keep the automation stuff out of gui.