bgrimstad/splinter

R package for splinter

berndbischl opened this issue · 2 comments

berndbischl commented

Dear splinter team,

I am thinking about making splinter available for R.
I am doing that here:
https://github.com/berndbischl/splinter-r-pkg

Please note:
At the moment this is simply me, trying out how feasible this is. The repo is rather unfinished.

What I would like to know now:

  1. Are you OK with this?

  2. Anything, especially license-wise I should know of or consider?

  3. What is your project status? Are you still working on this?

Best
Bernd

gablank commented
  1. Absolutely, this is awesome!
  2. Not that I am aware of, the license we use should be very liberal.
  3. We are absolutely still working on this, although progress have been slow for some time now. We are planning to put more work into SPLINTER come late summer / autumn.

Please note that the API of SPLINTER has historically been very volatile as we want it to be as good as possible. I can see the approach you've taken with copying the entire project to require a lot of manual work whenever we update the library, maybe you should include SPLINTER as a git submodule or something similar?

One more thing, the BSpline class has a method called clone() which returns a pointer to a copy of the BSpline. Maybe you could use that to avoid implementing build2()?

Overall, this is awesome and I'm sure @bgrimstad agrees with me on that!

Regards,
Anders.

berndbischl commented

Anders,thx a lot for your quick and helpful reply.

I can see the approach you've taken with copying the entire project to require a lot of manual work whenever we update the library, maybe you should include SPLINTER as a git submodule or something similar?

I will look into this, but currently, this seems really simple and unproblematic. It could be easily scripted.
A potentially "worse" problem is that I should not copy your Eigen-dirs but rather link vs. RcppEigen. I already tried that, but there seems to be some version inconsistency then?
I have to investigate this better, I only looked at it for 10 min, then copied all of it. Solving that would be a worthwhile step forward for me.

One more thing, the BSpline class has a method called clone() which returns a pointer to a copy of the BSpline. Maybe you could use that to avoid implementing build2()?

Thanks! I somehow missed that...
I think that copy is not so expensive, so your suggestion is probably the better approach.
Really great that you took the time to even dig into my unfinished stuff