bgrins/devtools-snippets

Update 'all on one page' snippets

ljcl opened this issue · 6 comments

ljcl commented

The querystrings.js on the github page differs slightly from the source on github, and returns an error when run whereas the source does not.

Might be worth an update!

The code, or the screenshot? I think the code is in sync unless if I'm missing something

hvsw commented

The searchvalue argument in replace function. "//g" and "/+/g"

return { "Key": qs.split("=")[0], "Value": qs.split("=")[1], "Pretty Value": decodeURIComponent(qs.split("=")[1]).replace(//g," ") }

return { "Key": qs.split("=")[0], "Value": qs.split("=")[1], "Pretty Value": decodeURIComponent(qs.split("=")[1]).replace(/+/g," ") }

Ah I see that now, thanks. Maybe is a bug with the rakefile at: https://github.com/bgrins/devtools-snippets/blob/master/Rakefile, because gh-pages is up to date after running rake build

Hm, well running pygmentize -f html snippets/querystringvalues/querystringvalues.js seems to produce the correct output so it's not that

And it appears OK in the snippets.json file: https://bgrins.github.io/devtools-snippets/snippets.json

Well, I'm not sure why but the /+/g is still there in the markup variable before the call to with_markup = template.gsub(regex, markup) in the rakefile:

with_markup = template.gsub(regex, markup)
. After this line, with_markup seems to be //g as far as I can tell.