bguerout/jongo

Dependency convergence error for jackson-annotations

Closed this issue · 4 comments

It seems that jongo v1.3.0 depends on jackson-annotations v2.7.3.

The problem is that jongo also depends on jackson-databind v2.7.3 which is transitive dependent on a different version of jackson-annotations - v2.7.0.

This can be resolved on the client side using exclusion and manual inclusion, which is not a very good approach. In the future, a newer jackson-annotations might be used but the client will forget to update the code.

Can you fix the dependency to depend on jackson-annotations v2.7.0? Thanks.

Hello,

I've ran mvn dependency:tree -Dscope=runtime on 1.3.0 tag but jackson-databind and jackson-annotations seems not to have transitive dependencies.

mvn dependency:tree -Dscope=runtime
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Jongo 1.3.0
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ jongo ---
[INFO] org.jongo:jongo:jar:1.3.0
[INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.7.3:compile
[INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.7.3:compile
[INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.7.3:compile
[INFO] \- de.undercouch:bson4jackson:jar:2.7.0:compile
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.897 s
[INFO] Finished at: 2016-12-01T21:47:38+01:00
[INFO] Final Memory: 17M/328M
[INFO] ------------------------------------------------------------------------

What will happen if you remove the scope param?

Anyhow, I don't think mvnrepository.com lies:

Jongo 1.3.0:
image

jackson-databind 2.7.3:
image

This is strange but jackson-databind seems not to specify a version for jackson-annotations
https://oss.sonatype.org/service/local/repositories/releases/content/com/fasterxml/jackson/core/jackson-databind/2.7.3/jackson-databind-2.7.3.pom

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>

Here is the full dependencies tree of jongo 1.4.0-SNAPSHOT :

[INFO] org.jongo:jongo:jar:1.4.0-SNAPSHOT
[INFO] +- org.mongodb:mongo-java-driver:jar:3.4.0:provided
[INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.7.8:compile
[INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.7.8:compile
[INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.7.8:compile
[INFO] +- de.undercouch:bson4jackson:jar:2.7.0:compile
[INFO] +- junit:junit:jar:4.10:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.1:test
[INFO] +- org.assertj:assertj-core:jar:1.4.0:test
[INFO] +- org.mockito:mockito-all:jar:1.9.0:test
[INFO] +- com.google.caliper:caliper:jar:0.5-rc1:test
[INFO] |  +- com.google.code.findbugs:jsr305:jar:1.3.9:test
[INFO] |  +- com.google.code.gson:gson:jar:1.7.1:test
[INFO] |  +- com.google.guava:guava:jar:11.0.1:test
[INFO] |  \- com.google.code.java-allocation-instrumenter:java-allocation-instrumenter:jar:2.0:test
[INFO] |     +- asm:asm:jar:3.3.1:test
[INFO] |     +- asm:asm-analysis:jar:3.3.1:test
[INFO] |     +- asm:asm-commons:jar:3.3.1:test
[INFO] |     +- asm:asm-tree:jar:3.3.1:test
[INFO] |     +- asm:asm-util:jar:3.3.1:test
[INFO] |     \- asm:asm-xml:jar:3.3.1:test
[INFO] +- de.flapdoodle.embed:de.flapdoodle.embed.mongo:jar:1.47.3:test
[INFO] |  \- de.flapdoodle.embed:de.flapdoodle.embed.process:jar:1.41.1:test
[INFO] |     +- commons-io:commons-io:jar:2.4:test
[INFO] |     +- org.apache.commons:commons-lang3:jar:3.1:test
[INFO] |     +- net.java.dev.jna:jna:jar:4.0.0:test
[INFO] |     +- net.java.dev.jna:jna-platform:jar:4.0.0:test
[INFO] |     +- org.apache.commons:commons-compress:jar:1.3:test
[INFO] |     \- org.slf4j:slf4j-api:jar:1.7.10:test
[INFO] \- org.reflections:reflections:jar:0.9.9-RC1:test
[INFO]    +- org.javassist:javassist:jar:3.16.1-GA:test
[INFO]    \- dom4j:dom4j:jar:1.6.1:test
[INFO]       \- xml-apis:xml-apis:jar:1.0.b2:test
stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.