Queued Requests bug

Question

Queued Requests bug

JatinderSingh opened this issue 12 years ago · 8 comments

Hey

The variable queuedRequests in http-client / src / main / java / com / biasedbit / http / client / AbstractHttpClient.java is never decremented in case of failures(cannot connect etc), because of same even if eventQueue is empty the requests may be rejected stating eventQueue is full.

Thanks & Regards
Jatinder

Answer 1 · 2012-06-04T07:54:36.000Z

Thanks for the heads up, will look into it ASAP.

Answer 2 · 2012-06-05T09:38:28.000Z

One of the possible fixes for same could be your context method failAllRequests returning number of requests it failed and you update your queuedRequests counter from same.

Answer 3 · 2012-11-26T10:11:17.000Z

Hi,

I think i've just come across this bug too. Can you tell me if this got looked at and/or a solution suggested?

TIA,

Andy

Answer 4 · 2012-11-26T10:14:52.000Z

Andy, I still haven't addressed this issue; it just got higher on my priority list as I've ran into it on the Droplr stack as well. I can't promise an ETA but I'm aiming to have it fixed by the end of the week.

Answer 5 · 2012-11-26T10:19:58.000Z

Thanks for the speedy response! And thanks also for a very useful bit of software :)

Answer 6 · 2013-02-18T12:38:12.000Z

Hey

I have pushed the fix in my fork.

Answer 7 · 2013-04-06T03:52:21.000Z

@JatinderSingh can you please open a pull request? Thanks!

Answer 8 · 2013-04-17T19:02:17.000Z

This has been fixed in dev branch. As soon as I finish writing tests for the pipelining connection I'll add a page on the wiki with the upgrade guide from 1.0.0 to 2.0.0.