Can we remove kepubify installation from test suite?

Question

Can we remove kepubify installation from test suite?

Closed this issue 10 days ago · 4 comments

Answer 1 · 2024-12-16T15:20:53.000Z

You can, but then you need to remove the phpunit tests that uses Kepubify or mock the class so it doesn't have to call the kepubify binary.

Answer 2 · 2024-12-19T06:57:40.000Z

@ragusa87 but the binary is already in the image, so why download it a second time?

Answer 3 · 2024-12-19T07:16:12.000Z

Well, I would say that I added it in the pipeline as it's wasn't in the image at the time, or because the path was misconfigured. Or because the docker image was not used. I don't know.

I can indeed have a fresh look

Answer 4 · 2024-12-19T07:17:12.000Z

I tried and realised that we are indeed not using the image. it's closed, thanks