bigbn/drop-down-terminal-x

URLs should be clickable

szarnyasg opened this issue · 1 comments

szarnyasg commented

Describe the bug
I'm curious how to make URLs clickable in Drop Down Terminal X.

To Reproduce
Steps to reproduce the behavior:

  1. Open Drop Down Terminal X
  2. Run echo https://github.com
  3. The resulting text should be clickable.

I believe the links in the terminal should be clickable. For comparison, using the GNOME terminal, the string https://github.com:

  • get underlined when hovered,
  • is clickable with the Ctrl key.

In Drop Down Terminal X, the link doesn't get underlined and isn't clickable.

Expected behavior
A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

  • Distro: Fedora
  • Gnome-version: 3.36.7
  • Extension-version 16
  • Xorg or wayland: Wayland

Context
I'm not sure if this is currently supported by Drop Down Terminal X. I found a related issue for Drop Down Terminal and it seems the URL handling code is present in this repository as well:

drop-down-terminal-x/dist/terminal.js

Line 94 in 9850f07

const UrlPathPattern = '(?:(/' + UserCharsClassPattern + '+(?:[(]' + UserCharsClassPattern + '*[)])*' + UserCharsClassPattern + '*)*' + PathTermClassPattern + ')?';

szarnyasg commented

I've upgraded to the code on master and it works now. Thanks!