Mixed Indention style
Closed this issue · 5 comments
It looks like this project uses a mixed space/tabs indention style, which makes it hard to read on github. Github shows tabs as 8 spaces, this project seems to use 4 spaces per tab. I dont know if you can configure the tab size in github.
OK, I have changed the "Tab size preference" in my GitHub-account from 8 to 4.
Please test again...
I fixed this the same way as you, switching it in the github preferences. But this is only a user preference, it may break the code styling in another project. Dont know if there is a corresponding option as repository option.
But this is only a workaround. The real solution would be to switch the indention style of the sourcecode to tabs or spaces, not both. Because its only a cosmetic change: if you touch the code the next time, also do a reformating. Most editors have a function for doing this automatically.
OK, I will fix that with PhpStorm.
OK, I have now reformated most of the PHP files with PHPstorm.
Can you test again?
Looks ok now with the default github settings.