billyrieger/bimap-rs

impl DoubleEndedIterator for IntoIter

Closed this issue · 5 comments

I noticed that DoubleEndedIterator could be implemented for the internal IntoIter structure. This would add on methods such as rev() next_back()

I'll likely make a fork with the appropriate modifications, and open up a pull request if all looks good to you.

Also, could you note somewhere in the documentation if ordering is preserved during iteration, thanks.

Yes, I'd be happy to review a pull request with those changes. The iteration order is preserved for BiBTreeMap but not for BiHashMap. I can make a note of that in the module documentation.

flokli commented

@Skarlett did you get around to open that PR? I'm currently trying to use the *_range methods to find the next neighbor, which also only works into the increasing direction.

@Skarlett did you get around to open that PR? I'm currently trying to use the *_range methods to find the next neighbor, which also only works into the increasing direction.

Ah, sorry. I've been busy under a new umbrella and haven't gotten to writing it.

Isn't it already implemented?

impl<L, R> DoubleEndedIterator for IntoIter<L, R> {

flokli commented

Yes, you were right. Sorry for the noise. Looks like this issue can be closed.