bingos/devel-patchperl

build failure on macOS 10.15 with ithread

Closed this issue · 2 comments

Perl 5.28.1, 5.28.0, 5.24.2 builds fail on macOS 10.15 with ithread (-Duseithreads), Devel-PatchPerl 2.00 is applied.
ref. https://github.com/shogo82148/actions-setup-perl/runs/1366242512?check_suite_focus=true

it relates to Perl/perl5#15524 and has been already fixed on Perl 5.30 by Perl/perl5@1a833e4

Is this commit acceptable?

I found Perl/perl5#15524 is already ported as #26, but it is not applied to Perl 5.24.2.
The patch is officially released as 5.24.3, so we need it in Perl 5.24.2. #49 fixes it.

failures of Perl 5.28.1, 5.28.0 builds are another reason.

2020-11-07T02:24:52.0832770Z Extracting zipdetails (with variable substitutions)
2020-11-07T02:24:52.3168310Z cd dist/Storable ; DYLD_LIBRARY_PATH=/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/9yv3AHhFQF/perl-5.28.0 /Applications/Xcode_12.app/Contents/Developer/usr/bin/make lib/Storable/Limit.pm
2020-11-07T02:24:52.3327530Z /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/9yv3AHhFQF/perl-5.28.0/dist/Storable/../../miniperl "-I../../lib" -MExtUtils::Command -e 'mkpath' -- ../../lib
2020-11-07T02:24:52.3798700Z "../../perl" "-I../../lib" "-I../../lib" stacksize --core
2020-11-07T02:24:52.3870910Z dyld: Library not loaded: /Users/runner/hostedtoolcache/perl/5.28.0/x64/lib/5.28.0/darwin-thread-multi-2level/CORE/libperl.dylib
2020-11-07T02:24:52.3937760Z   Referenced from: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/9yv3AHhFQF/perl-5.28.0/dist/Storable/../../perl
2020-11-07T02:24:52.3938610Z   Reason: image not found
2020-11-07T02:24:52.3939440Z make[1]: *** [lib/Storable/Limit.pm] Abort trap: 6
2020-11-07T02:24:52.3940110Z make: *** [dist/Storable/lib/Storable/Limit.pm] Error 2
2020-11-07T02:24:52.3940770Z make: *** Waiting for unfinished jobs....
2020-11-07T02:24:53.3155160Z rm -f ../../lib/auto/XS/APItest/APItest.bundle
2020-11-07T02:24:53.3181880Z cc  -mmacosx-version-min=10.15 -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector-strong  APItest.o XSUB-undef-XS_VERSION.o XSUB-redefined-macros.o core.o exception.o notcore.o  -o ../../lib/auto/XS/APItest/APItest.bundle  \
2020-11-07T02:24:53.3184160Z 	      \
2020-11-07T02:24:53.3185980Z 	  
2020-11-07T02:24:53.3768680Z chmod 755 ../../lib/auto/XS/APItest/APItest.bundle

Thank you for merging my pull request!