biomejs/biome

๐Ÿ› VS Code extension: Poor support for multi-folder workspaces

EvHaus opened this issue ยท 19 comments

Environment information

CLI:
  Version:                      1.5.2
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v21.1.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.10.2"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

I have several "Folders" in my VS Code "Workspace". Like this:

image

Some of those "Folders" are projects that use Biome, and some aren't. Biome's VS Code extension doesn't handle this very gracefully. There are several issues:

Bug 1: First "Folder" in the VS Code "Workspace" must be a Biome project for any others to work

If you order the "Folders" in your "Workspace" such that the top-most one doesn't have Biome installed, none of the files you open in the older "Folders" will run through Biome checks. It seems like the top-most "Folder" must be a Biome project for the Biome VS Code extension to do anything and will instead show this warning:

image

Bug 2: Biome runs on "Folders" that aren't Biome projects

The inverse of Bug 1 also exists, where if the top-most "Folder" is a Biome project, all other "Folders" will get checked by Biome, even if they don't have Biome installed or configured.

Bug 3: Duplicated problems

For every folder with Biome installed, the "Problems" tab shows duplicate Biome errors:

image

Note how each of those problems is the same problem on the same line & column. It's a duplicate.

Expected result

Expectations listed above in each bug

Code of Conduct

  • I agree to follow Biome's Code of Conduct

Our LSP doesn't support workspaces yet. We have a task to implement and support them: #1573