bird-house/finch

"output_name" broken for indicators

Closed this issue · 0 comments

Description

"output_name" gets listed as an input by the indicator WPS processes, but when given those processes fail with "TypeError got an unexpected keyword argument output_name". The error goes back to xclim : the problem is that the argument is passed to compute_indices and then to the indicator. But it's a finch-only think, xclim doesn't recognize it and fails.

Environment

  • Finch version used, if any: 0.8.2, PAVICS andmaster
  • Python version, if any: 3.9 and maybe others
  • Operating System: Linux

Steps to Reproduce

import os
import xarray as xr
from birdy import WPSClient

pavics_url = "https://pavics.ouranos.ca/twitcher/ows/proxy/finch/wps"
url = os.environ.get("WPS_URL", pavics_url)
verify_ssl = True if "DISABLE_VERIFY_SSL" not in os.environ else False
wps = WPSClient(url, verify=verify_ssl)

tasmin = "https://pavics.ouranos.ca/twitcher/ows/proxy/thredds/dodsC/birdhouse/testdata/flyingpigeon/cmip3/tasmin.sresa2.miub_echo_g.run1.atm.da.nc"

o = wps.tn_days_below(
    tasmin=tasmin
    thresh="-5 degC",
    freq="YS",
    check_missing="pct",
    output_name="an_output_name",
)