Dockerhub does not build releases
huard opened this issue · 15 comments
Description
DockerHub does not seem to auto-build releases. My guess is that the regex is wrong since we're using a v before the version number.
I might not have enough permissions on github.com/bird-house/flyingpigeon repo?
I am unable to reconfigure the docker build config.
Should we agree if we want tag version to be prefixed with v or not? The same problem (no autobuild from docker hub) happended before but this time the v was removed from the tag ! See bird-house/finch#38
I suggest we keep the v and modify the regexp.
I had the same problem. Do you think it's because it's Carsten's ssh key that is connected ?
Do you think it's because it's Carsten's ssh key that is connected ?
Should not relate to ssh key but I am unsure on this one. Do you have admin on the flyingpigeon repo or the entire bird-house org on github? I was admin on the entire Ouranosinc org so that might have helped.
Yes, I'm an owner.
If you are already owner of the entire bird-house org on github, then I don't have other ideas.
@davidcaron you were able to configure the Finch which has the same setup (bird-house github and birdhouse docker hub) can you try to edit the docker build config of this Flyingpigeon to see if you have permissions?
This works for magpie, no v in version tag
@davidcaron can you still do the test. What @fmigneault replied is not a good test since magpie is under Ouranosinc github paired with pavics docker hub. Have to compare apple with apple.
What we need is bird-house github paired with birdhouse docker hub. Your Finch and this Flyingpigeon is in this scenario. You were able to configure Finch so I wonder if you can configure this Flyingpigon as well.
If you can, then we can drill down to what permissions you have that David and I are missing. If you can not, then it's something else, but at least we can eliminate missing permissions as the possible cause.
@tlvu
It seems @Zeitsperre has the permissions. I think we can fix this on our end.
Scrap that, we only have the permission for the pavics fork.
I got the permissions. For some reason, the github link was broken. I re-linked it. Now the build rules are defined like in my above example for branch master & regex tag.
Can you modify the build rules so that it will work with or without v ? It seems the default in most projects is to use v for tags.
Wait, I now have permissions too to change it ! I'll try it myself.
Added a rule that includes "v" on dockerhub.
In the github webhooks config, I checked branch and tag as an event that triggers the webhook.
Deleted and pushed the 1.5 tag.
Build has now started on dockerhub.
I also have access now, probably what Francis did fixed it.
I removed "Build Caching" for the Tag builds. This ensure every layer is rebuilt from scratch instead of reusing an existing layer that might not be up-to-date. The price to pay is the build is slower.
Ex: a layer with "conda update -n base conda" might not actually update to the latest conda if a layer with the same "text" existed on the build host and is being reused. I assume the build host are being flushed from time to time but I'd rather not rely on luck.
