bisq-network/bitcoinj

Transaction can serialize and deserialize according to Segwit

ManfredKarrer opened this issue · 3 comments

ManfredKarrer commented

I have not looked closer but that might be a critical issue we should get merged to our fork:

Transaction can serialize and deserialize according to Segwit (BIP144)
bitcoinj@b9c983e

@cbeams @ripcurlx Maybe we should try to get that into the next release as well.

oscarguindzberg commented

I just had a look at this issue.
This is the actual commit that is part of bitcoinj master bitcoinj@648655d
I see no need to merge this ASAP.
Segwit is a soft fork, so it is backwards compatible. Meaning any bitcoin node that does not support segwit (eg bitcoinj before 0.15 release) is still part of the network and need not be changed as long as it follows the longest chain.
Peers won't send txs serialized with the new format to peers that don't support segwit yet.

BTW, have a look at https://groups.google.com/forum/#!topic/bitcoinj/qjxgcpKak3s for the discussion about releasing bitcoinj 0.15 with segwit support.

  • 👍1
ManfredKarrer commented

So we can close that issue, right?

oscarguindzberg commented