bitExpert/magento2-force-login

Can not create new password on Magento 2.3.3

jankovandeventer opened this issue · 8 comments

jankovandeventer commented

Preconditions

Magento 2.3.3
"bitexpert/magento2-force-customer-login": "^4.0",

Magento Version :
Open Source (CE)

Force Login Module Version : 4.0

Third party modules:
Not a single one that interferes with his process

Steps to reproduce

  1. Install and enable bitexpert
  2. Request a new password
  3. Click on the create new password link in the email

Expected result

  1. Go to create new password page with form

Actual result

  1. infinite redirect

Batao.zip

I created a plugin with a pregmatch on the create password url to bypass the Login Check.
This was the quickest workaround, but I bet you can make a nicer solution in the module itself, by adding a check for the create password on Magento 2.3.3+

Thanks for looking into it, and if I can create a PR with a solution, let me know. Would be happy to contribute.

der-workfloh commented

Hi @jankovandeventer ,

did you try and use the new 4.0.1 release which addresses the issue with the password creation?

Best regards

  • 👍1
jankovandeventer commented

Hello, must have just missed this release. Will try that.

manuelcanepa commented

Maybe magento/magento-coding-standard is the problem. I have magento/magento-coding-standard:~3.0.0 in my composer and bitexpert/magento2-force-customer-login was installed on version 4.0.0

DanielRuf commented

See also 350b32c vs e1485c4

DanielRuf commented

In the meantime you can try the Git URL or dev-master.

shochdoerfer commented

@manuelcanepa my bad, I forgot to update the version information in composer.json. I just released a new version 4.0.2 which is already available via Packagist.

  • 👍1