bitcoin-core/ctaes

signed overflow on 16bit

tankf33der opened this issue · 5 comments

FYI.

I have setup demo repo to run ctaes tests under TIS-CI.

Report of test run you can find here and check "undefined behaviour" in list for 16bit platforms.

Known members of TIS team in github are: @pascal-cuoq and @guillaumemillot

sipa commented

@tankf33der Thanks for analyzing this. Could you see if #18 fixes this?

@tankf33der Thanks for analyzing this. Could you see if #18 fixes this?

@sipa, LoadByte function fixed and now TIS found next one. I could somehow enable option "dont stop after first alarm and keep running", but lets do it one by one.

sipa commented

@tankf33der Try again.

@sipa

All green, issue closed.

sipa commented

Awesome, thanks!