Remove trailing full stop from log lines
Opened this issue · 3 comments
Describe desired feature
This is pretty opinionated, but I think log lines should not end in full stop
Use case for feature
Being able to copy info from the terminal without carrying over the full stop. Right now, if you try to copy data from the terminal by double-clicking on it to select it (such as node ids, hashes, ...) the full stop will be carried over. Here are some examples:
> 2023-10-10T15:50:09.139Z INFO [sim_cli] Connected to alice - Node ID: 02c7e2f01ea946252b29a2e24629d67df3740f3db448ec42a1bccb52e2b7482b2a.
02c7e2f01ea946252b29a2e24629d67df3740f3db448ec42a1bccb52e2b7482b2a.
> 2023-10-10T15:50:15.195Z DEBUG [sim_lib] Tracking payment outcome for: 6fd79189307a9db7e685c0ffcd909d46a5a25f2cb736753080e7092d856ab47a.
6fd79189307a9db7e685c0ffcd909d46a5a25f2cb736753080e7092d856ab47a.
Would you like to contribute code for this feature?
Sure, if we reach consensus about it
I will love to contribute to resolve this.
I will love to contribute to resolve this.
I'm fine with doing one full sweep to update this, it is an aesthetic change that's going to cause a ton of rebase conflicts. We've got some big PRs in flight at the moment, so:
- Feel free to open, but expect to rebase a lot yourself because they'll take merge precedence
- Hold off till a quieter time (I'll try remember to ping on the issue when I think the moment is right)