Do not require `https` in `address` fields on the simulation file
Opened this issue · 4 comments
Currently, we force addresses in the simulation file to start with https://. That's not really user-friendly.
Make it so the can be specified but not required (as in, if they are not required we just add it in).
Motivated by #152 (comment)
I suspect this needs a tonic-lnd update to use http connector. Will look into it :)
Oh, I was really thinking of something pretty straightforward here, like an if checking the string front to strip the protocol, if it is not https complain, and if it does not have one just add it.
If the only way to use tonic is via https, it may be worth adding the patch upstream, otherwise I wouldn't bother.
Oh, I was really thinking of something pretty straightforward here, like an if checking the string front to strip the protocol, if it is not https complain, and if it does not have one just add it.
Quick UX win for SimLn, yes
If the only way to use tonic is via https, it may be worth adding the patch upstream, otherwise I wouldn't bother.
Yeah the current version of tonic requires https per this comment so I would look at the reasons why.