Refactor: Use From<PaymentPreimage> when constructing PaymentHash
Opened this issue · 3 comments
#165 introduces the use of PaymentHash
manually building from PaymentPreimage
. Recently, LDK added the ability to build the former from the latter into their API: lightningdevkit/rust-lightning#2916.
Update our LDK version and replace the manual construction from the corresponding call when it gets released
Should I go ahead and send a draft PR for it?
lightningdevkit/rust-lightning/pull/2916 hasn't landed in a release yet so we should wait for that.
If you'd like something to pick up, we bumped our lightning version but never finished #131 to update the way that we handle feature vectors.
Should I go ahead and send a draft PR for it?
lightningdevkit/rust-lightning/pull/2916 hasn't landed in a release yet so we should wait for that.
If you'd like something to pick up, we bumped our lightning version but never finished #131 to update the way that we handle feature vectors.
Ok great. I'll jump on that then. Thank you.