bitcoin-dev-project/sim-ln

Refactor: Use From<PaymentPreimage> when constructing PaymentHash

Opened this issue · 3 comments

sr-gi commented

#165 introduces the use of PaymentHash manually building from PaymentPreimage. Recently, LDK added the ability to build the former from the latter into their API: lightningdevkit/rust-lightning#2916.

Update our LDK version and replace the manual construction from the corresponding call when it gets released

Anyitechs commented

I'll like to work on this issue. Should I go ahead and send a draft PR for it?

cc: @sr-gi @carlaKC

  • 👍1
carlaKC commented

Should I go ahead and send a draft PR for it?

lightningdevkit/rust-lightning/pull/2916 hasn't landed in a release yet so we should wait for that.

If you'd like something to pick up, we bumped our lightning version but never finished #131 to update the way that we handle feature vectors.

  • 👍2
Anyitechs commented

Should I go ahead and send a draft PR for it?

lightningdevkit/rust-lightning/pull/2916 hasn't landed in a release yet so we should wait for that.

If you'd like something to pick up, we bumped our lightning version but never finished #131 to update the way that we handle feature vectors.

Ok great. I'll jump on that then. Thank you.