catch fewer errors
Closed this issue · 2 comments
pinheadmz commented
I think we need to be less afraid to raise exceptions. try/except blocks like the one below are counter productive. In recent CI runs for example, wait_for_health()
fails, meaning apply_network_conditions()
is just skipped, but the test continues to run along.
Somewhat related to #198
Lines 472 to 485 in 4410200
matthew-chaincode commented
Hi this is a test comment that is very spammy. I should be blocked and banned for 24 hours
willcl-ark commented
Fixed in /dev branch