bitcoin-dev-project/warnet

Ruff CI does not appear to be checking PR branch

Closed this issue · 2 comments

mplsgrant commented

I wonder if we should separate out our CI in to a pull_request_target section and a pull_request section. I see that some of the workflow requires github secrets, and so I think that means it must use pull_request_target. The ruff workflow does not need secrets which means we can package it into an on: pull_request workflow and that would help us avoid this issue.

willcl-ark commented

I think this should be solved by the recent CI updates, closing for now...

(p.s, I do' kinda like the idea of having a seperate workflow just using pull_request for ruff, but I CBA personally to create the dependant workflows, so leaving for now. Would probably review such a PR though)

  • 👍1