bitcoindevkit/bdk

Upgrade rust-bitcoin to 0.32

Closed this issue · 9 comments

notmandatory commented

Describe the enhancement

The LDK team would like to use rust-bitcoin version 0.32 so BDK should update too. To do so we also need to update the following crates to the versions that depend on rust-bitcoin 0.32:

Use case

Updating to rust-bitcoin 0.32 removes the need for a specific no-std feature, it will be implied by not enabling the std feature. It also includes a new io crate.

Additional context

https://discord.com/channels/753336465005608961/753367451319926827/1228314439133171795

oleonardolima commented

I'm willing to give a try on this one.

  • 👍2
notmandatory commented

Thanks @oleonardolima you'll need to keep an eye to see when rust-miniscript and rust-bitcoincore-rpc are ready. Feel free to start making PRs for any of the crate that only need rust-bitcoin updated to 0.32.

  • 👍1
notmandatory commented

Another thing this PR should fix is the broken docs.rs for bdk_persist. I think they're breaking because it doesn't build with default features.

https://docs.rs/crate/bdk_persist/0.1.0/builds/1208655

oleonardolima commented

Thanks @oleonardolima you'll need to keep an eye to see when rust-miniscript and rust-bitcoincore-rpc are ready. Feel free to start making PRs for any of the crate that only need rust-bitcoin updated to 0.32.

Sure, I'll keep an eye and initially start from other crates.

Another thing this PR should fix is the broken docs.rs for bdk_persist. I think they're breaking because it doesn't build with default features.

https://docs.rs/crate/bdk_persist/0.1.0/builds/1208655

Cool, I'll check if it solves the docs once the PR is done.

  • 👍1
ValuedMammal commented

@notmandatory Would #1423 fix the docs.rs fail? - Oh I see you mentioned it wouldn't be needed after the rust-bitcoin upgrade. Still maybe a quick fix in the interim

  • 👍1
ValuedMammal commented

I forgot to mention there was a suggestion #1412 (comment) for a better crate description for bdk_persist that maybe we can fix when the opportunity arises.

  • 👍1
oleonardolima commented

update: Some of the rust-bitcoin crates have been released, and the rust-electrum-client, and electrsd are ready to review (depends on each other).

EDIT: habemus rust-miniscript 🥳

oleonardolima commented

NOTE: it's not done yet, only consider it done after #1448, mistakenly marked as completed probably because my comment partially fixes ... at other PR 😅

  • 👍1
notmandatory commented

@oleonardolima I published the 0.9.0 rust-hwi crate, thanks for keeping on it! 🎉 https://crates.io/crates/hwi