Changing between different wallets switches to overview tab
Closed this issue · 6 comments
Is there an existing issue for this?
- I have searched the existing issues
Current behaviour
When using multiple wallets (switching them) If you do this in the Transactions tab, instead of displaying the transactions of the selected wallet it will switch to the Overview tab.
It only happens in the Transactions tab, the other tabs (Overview, Send or Receive) work as expected.
Expected behaviour
It should display the transactions of the selected wallet instead of switching to overview.
Steps to reproduce
Go to the Transactions tab and select a different wallet.
Relevant log output
No response
How did you obtain Bitcoin Knots
Pre-built binaries
What version of Bitcoin Knots are you using?
Bitcoin Knots version v26.1.knots20240513
Operating system and version
Fedora Workstation 40 (gnome)
Machine specifications
No response
Confirmed. Bug was introduced by bitcoin-core/gui#815, and will be resolved in next version
Please confirm this is fixed in 27.1.knots20260621 and close if so
I confirm, fixed
Steps to reproduce
Go to the Transactions tab and select a different wallet.
@Tracachang, just to be clear, you meant: selecting a different wallet by "Open Wallet" menu action? Switching among wallets from the wallets (already loaded) combo box (at the top right section of the main window), won't produce such change in the behaviour. Thanks!
Steps to reproduce
Go to the Transactions tab and select a different wallet.
@Tracachang, just to be clear, you meant: selecting a different wallet by "Open Wallet" menu action? Switching among wallets from the wallets (already loaded) combo box (at the top right section of the main window), won't produce such change in the behaviour. Thanks!
yes, switching among wallets from the wallets (already loaded) combo box (at the top right section of the main window)
yes, switching among wallets from the wallets (already loaded) combo box (at the top right section of the main window)
Mmm... the line that was causing that behaviour of switching from transactions to overview tab is this one:
if (historyAction->isChecked()) gotoOverviewPage();
That's inside the function void BitcoinGUI::enableHistoryAction(bool privacy) which was referenced/ called from 2 places... when the user ticks the "mask values" from the Settings menu (pls click here to watch animated gif).
The idea (introduced in #708) was to move from the transaction tab to the overview tab since it was going to be disabled anyways.
The 2nd place where this function was called was in addWallet (still is in bitcoin-qt but bitcoin-core/gui/pull/815 is removing it), which is called when a new wallet is created or opened/ loaded, and here we can see the undesired secondary effect you were mentioning on this issue (pls click here to watch animated gif).
Switching among loaded wallets from the combo box doesn't switch between tabs (this is still in bitcoin-qt, unless there's something in bitcoinknots that causes it and I'm not aware of:
