bitfireAT/cert4android

Fix code scanning alert - Use of a broken or risky cryptographic algorithm

Closed this issue · 4 comments

Is MD5 secure enough to display a fingerprint to let users decide whether the certificate is trusted? Otherwise just keep SHA1

Tracking issue for:

Browsers show SHA-1 and SHA-256 (and no MD5), so I think we can remove MD5 too:

Bildschirmfoto vom 2022-11-29 14-56-27

Well, MD5 is not proper hashing, so I understand that it might be deprecated. I would personally use SHA-1.

For the end user it's almost the same, just numbers and letters.

Yes I'd do like Firefox and display the SHA-1 and the SHA-256 hash. So we just need to replace MD5 with SHA-256 :)

Fixed with 683d211