bitinerant/bitburrow

Fix remaining line length issues in main.py

Closed this issue · 4 comments

goldseven commented

The remaining line length PEP8 issues in main.py are within a complex shell script. This is the last remaining style issue that I'm not comfortable fixing as @bitinerant knows more about how this should work.

Once that is fixed, I think we're ready to start using black to automatically format all of the projects code and then it's mechanical how things should look and everything will pass style checks all the time.

bitinerant commented

@goldseven - There are actually 3 remaining issues here:

  • Shell commands as you noted (I've already begun work on moving these out)
  • Long URLs (see commit 5d0f66d )
  • Marking which strings need translation, since black will convert strings to single quotes. I've been using double quotes for translatable and single quotes for non-translatable strings. I'm happy to use another system, but we need to find one that will hopefully work with whatever l10n method we end up using.
bitinerant commented

The "Marking which strings need translation" above is solved in #34.

Update: strings converted in commit 76dfac6.

bitinerant commented

Shell commands fixed in commit 6349733.

bitinerant commented

"Long URLs" issue resolved; see commit 5d0f66d.