bitjson/typescript-starter

Add tslint-language-service plugin

Closed this issue · 4 comments

  • I'm submitting a ...
    [x] feature request

  • Summary

tslint has a language service plugin so that tslint runs within the language service and shows linter failures in your editor as red squiggly underlines, the same as type errors.

https://www.npmjs.com/package/tslint-language-service

I'll make a PR at some point; just logging here for the time being.

Is there a reason this needs to be configured in every project? My editor (VS Code) has full TSLint language service support in any TypeScript project since I have the TSLint plugin installed.

I would think we’d would want to avoid non project-specific configuration of any kind for the starter.

Oh, I've not been following development for tslint-language-service. TIL, thanks!

But maybe it's good to wait till the vnext version leaves preview status.

Ya, I think it might be best for this starter to stick with the current stable setup.

I'd definitely be open to a PR adding it as an extra option, though.

I think it's safe to say this is "done" now – tslint is deprecated and this project has switched to eslint, and language services are now ubiquitous, so no additional changes need to be made in this project. 👍