bitjson/typescript-starter

use `--rootDir` in config files

Closed this issue · 2 comments

  • I'm submitting a ...
    [X] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary
    This is rather a suggestion to prevent future bugs, whenever --outDir is used, I would recommend setting --rootDir, see https://github.com/Microsoft/TypeScript/wiki/FAQ#why-does---outdir-moves-output-after-adding-a-new-file for more details.

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Thanks for sharing! I didn't know that. So right now our tsconfig.json includes:

{
  "compilerOptions": {
    "outDir": "build/main",

Should that be the following?

{
  "compilerOptions": {
    "outDir": "build/main",
    "rootDir": "./",

(Mind sending a pull request? Would love to have you as a contributor!)

Thanks @mhegazy!