Login error: Null value for $.viewer.message_threads.sync_sequence_id

Question

Login error: Null value for $.viewer.message_threads.sync_sequence_id

Opened this issue 7 years ago · 48 comments

ADMIN EDIT

This is already fixed in the latest release. This ticket is only open for visibility

Release notes: https://github.com/bitlbee/bitlbee-facebook/releases

Original ticket description

Got an Error: Failed to send message this morning and got disconnected from Facebook, and now I'm getting a Login error: Null value for $.viewer.message_threads.sync_sequence_id every time BitlBee reconnects to Facebook.

jashank commented 7 years ago

dup #130

dequis commented 7 years ago

fuck

😄3

Answer 1 · 2017-03-29T03:14:21.000Z

Yeah, I'm currently getting this issue too.

Answer 2 · 2017-03-29T03:59:02.000Z

same here. cant login because of it. seems like something has changed.

Answer 3 · 2017-03-29T04:09:25.000Z

I suspect this has something to do with Facebook dropping support for ancient versions of Messenger: https://messengerblog.com/general-messenger/update-on-support-for-older-versions-of-messenger-and-facebook-apps/

Answer 4 · 2017-03-29T04:11:02.000Z

See also: dequis/purple-facebook#306

Answer 5 · 2017-03-29T05:19:01.000Z

NOT a dup of #130. This message is NOT transient - it is a permanent error. something has changed server side, and this plugin won't work unless a workaround is enacted. Linking a closed bug and calling it a dup because the symptom is superficially the same is not helpful as it creates the impression the bug reports are invalid - there is a genuine issue here and it has been triggered by a serverside change which is why it's appearing in both implementations as per dequis/purple-facebook#306

Answer 6 · 2017-03-29T05:32:18.000Z

@exitdown: I accept that the original issue refers to a transient bug. However, I mildly disagree that bringing up a closed bug is not useful: similar prior issues may still be of relevance and providing some link to with associated information ensures there's more information available now, and there's continuity in the treatment. (I also note that dequis/purple-facebook#179 was brought up similarly.)

Answer 7 · 2017-03-29T06:15:25.000Z

@jashank yes - if you had added some context to that effect your point is valid - however by simply posting a "dup" with no context most people would read it as dismissive of the issue - which is why i made it clear in my subsequent post that it was not a dupe of that previously closed bug :) either way,hopefully now its obvious there's an issue here's hoping the protocol modifications are relatively easy so we can all get back to using this excellent software :)

Answer 8 · 2017-03-29T07:44:21.000Z

well, fuck.

Answer 9 · 2017-03-29T09:11:51.000Z

Fix 9390579

I'll prepare a release shortly.

edit nevermind see below

Answer 10 · 2017-03-29T09:28:01.000Z

[INFO] facebook: Parsing JSON: {"succeeded":false,"msgid":6252783076008029414,"errno":1545075,"errStr":"This app version no longer supports messaging. To continue to send and receive messages, please update your app to a newer version or use the mobile web version of Facebook.","isRetryable":false}

Answer 11 · 2017-03-29T09:37:03.000Z

At least this issue is something I predicted that could happen, but was hoping it wouldn't. The /send_message2 mqtt topic (that we use to send json messages instead of thrift) is very old.

Bad news is that I'll have to implement the newer, more complex one right now.

Good news is that we'll get stickers.

Answer 12 · 2017-03-29T09:46:26.000Z

thank you for your efforts dequis!

Answer 13 · 2017-03-29T10:14:53.000Z

Yes, thanks dequis! Been using the plugin for a while now and really appreciate it :)

Answer 14 · 2017-03-29T10:25:35.000Z

I tried the new plugin and now I get "Arguments are invalid"

Answer 15 · 2017-03-29T10:32:47.000Z

Same here, but I think that's what dequis was saying about having to implement complex stuff

Answer 16 · 2017-03-29T11:02:20.000Z

I can confirm this issue as well

Edit:

Maybe this should be opened as new issue?

I installed the latest commit: 20170329~~9390579~~279
Now I can login again. However, I can only receive messages, not send. When I send I get this in the &bitlbee buffer:

@root | facebook - Logging in: Fetching contacts
@root | facebook - Logging in: Connecting
@root | facebook - Logging in: Logged in
@root | facebook - Error: Failed to send message
@root | facebook - Signing off..
@root | facebook - Reconnecting in 5 seconds..
@root | facebook - Logging in: Fetching contacts
@root | facebook - Logging in: Connecting
@root | facebook - Logging in: Logged in

Answer 17 · 2017-03-29T11:23:54.000Z

@malinkb read up

Answer 18 · 2017-03-29T12:35:40.000Z

Please try latest master.

1629e2f fixes message sending - turned out to be just a boring "set user agent version" thing. The old-style /send_message2 message sending is still used by supported versions of the official app, and for the sake of not breaking more than needed now, I'm not changing it.

93a62d3 fixes invalid arguments errors when fetching channel lists.

edit: nope nevermind not yet

Answer 19 · 2017-03-29T12:42:45.000Z

And af132a8 fixes a last minute bug. You can test it now.

Answer 20 · 2017-03-29T12:44:32.000Z

Thanks dequis, currently being an idiot and failing to work out how to install it, but that's just me

Answer 21 · 2017-03-29T12:46:56.000Z

Builds should appear in the package repos shortly: https://build.opensuse.org/package/show/home:jgeboski/bitlbee-facebook

edit: done

Answer 22 · 2017-03-29T13:01:01.000Z

Thanks for such a fast fix & package!

Answer 23 · 2017-03-29T13:02:56.000Z

Works now. Thanks for fast fix :)

Answer 24 · 2017-03-29T13:08:52.000Z

Ping @spwhitton, this may be worth uploading to debian, too.

Answer 25 · 2017-03-29T13:59:39.000Z

@dequis Are you planning tagging a new release soon?

Answer 26 · 2017-03-29T14:39:33.000Z

Yeah I'll prepare the long overdue 1.1.0 release now.

Here's a long-form explanation of what happened here:

As others suggested, https://messengerblog.com/general-messenger/update-on-support-for-older-versions-of-messenger-and-facebook-apps/ is indeed relevant. They deploy to production on tuesdays which is when it broke.

I was aware of this, but, as far as I knew, nothing needed updating, because it says that versions older than 5 will be discontinued but we're compatible up to version 38, mostly. I suspected the /send_message2 method might go away, or that the "MQIsdp" connections would break (the latter are only used by the oldest bitlbee-versions). But neither of those were issues, as they seem to be used by versions newer than 5 (I tested 14 and 38 today)

Versioning in facebook is complicated, which is both good and bad. Good because it allows them to have excellent backwards compatibility (as far as they want to keep it). Bad because it's hard to understand where to draw the line on what a version means.

There were two fixes:

The graphql query hash to get the sequence id. Those hashes represent a textual graphql query stored in the server, and those queries are basically a way to tell the server "pick these fields from this deeply nested structure and return them with this other structure". We don't know what the exact query is, we just know the arguments and the result. Well, we don't exactly know the arguments, as evidenced by those errors some people got today. But they are discoverable with some effort.

So my best guess is that something in the underlying structure of the facebook graph API changed to stop supporting old clients (likely not directly related), and this means that the field that was accessed by the old hash was no longer there. The newer hash checks a different location, or filters it differently, or who knows what, but manages to access that field successfully. It also has different arguments so I'm only using it for the sync sequence number for now, while thread listing uses the other query, because everything else just works.
The version string in the MQTT CONNECT message. This was a surprise because it was previously empty and just worked, but it's how they chose to stop old versions from sending messages. I think that was the only intended breakage, and who knows, maybe the other issue is a bug that facebook should fix. Heh. Our code also likes to disconnect too easily on almost all errors, which seems to be a successful strategy overall.

Not too bad overall. Next time we won't have the surprise version check since we're sending a version exactly where they expect it. Also, I'm happy with the approach they've taken to deprecate very old versions. This announcement sounds like they are committing to 3 years or so of support for old versions, which sounds great.

EDIT: I should mention, the graphql hash for the first (and most important) fix was found by @EionRobb, go thank him too.

Answer 27 · 2017-03-29T15:01:59.000Z

(keeping this open for visibility)

Answer 28 · 2017-03-29T15:02:38.000Z

You're awesome, @dequis!

Answer 29 · 2017-03-29T15:13:07.000Z

Thanks for the quick fix @dequis. I tipped you some btc.

Answer 30 · 2017-03-29T15:58:28.000Z

https://github.com/bitlbee/bitlbee-facebook/releases/tag/v1.1.0

\o/

Answer 31 · 2017-03-30T17:35:42.000Z

Hi guys! It would be awesome to get a new debian-package as well... Do you think it's possible? Awesome response time on the patch! :) 👍

Answer 32 · 2017-03-30T19:54:44.000Z

The builds in https://build.opensuse.org/package/show/home:jgeboski/bitlbee-facebook happen automatically a few minutes after each commit.

Answer 33 · 2017-03-30T20:24:41.000Z

Aha. Sorry - Did not know that one. :) Thanks mate! Great!

Answer 34 · 2017-03-31T01:50:51.000Z

I just realized I had a problem and it's already fixed 👍

Answer 35 · 2017-04-03T14:44:17.000Z

Do I have to recreate the facebook account in bitlbee for this fix? I tried updating to 20170402~41382c1~288 while keeping the old config files, but I'm still getting the error when connecting to the facebook account.

Answer 36 · 2017-04-03T15:33:05.000Z

Recreating accounts is not needed. You do need to restart the bitlbee daemon and reconnect your irc client.

Answer 37 · 2017-04-05T08:45:40.000Z

I am still having this issue. Can you somebody give me clear suggestion?

Answer 38 · 2017-04-05T09:42:48.000Z

@lew1s did you

update bitlbee-facebook to latest git revision
restart bitblee daemon
/reconnect your IRC client to the bitlbee server?

If so, please open an issue with a bit more debug info, because this specific issue seems to be fixed for most people on this thread.

Answer 39 · 2017-04-05T20:39:15.000Z

@lew1s The issue was persisting for me too after following the above steps, and even after a complete reboot.

I was using the latest ubuntu 16.04 apt package of bitlbee (3.4.2), but I guess that was too old for this fix. I upgraded to 3.5.1+20170130+master+0-g262a82b-git using the packages from https://wiki.bitlbee.org/Packages. For 16.04, add deb http://code.bitlbee.org/debian/master/xenial/amd64/ ./ to your /etc/apt/sources.list.

Answer 40 · 2017-04-05T21:08:56.000Z

@thallada "was"? does it still not work?

Check that you're using the right bitlbee version with /ctcp root version and check that you're using the right plugin version with the plugins command (available in bitlbee 3.5+)

Answer 41 · 2017-04-05T21:13:14.000Z

@dequis sorry for not being clear. Upgrading to 3.5.1 fixed the issue for me.

Answer 42 · 2017-04-06T09:54:15.000Z

I am on windows and dont know where to update bitlbee-facebook. Is there some guide for windoes?

Answer 43 · 2017-04-06T17:28:52.000Z

@lew1s Are you sure you're not using purple-facebook instead? https://github.com/dequis/purple-facebook/wiki/Installing-on-Windows

I mean, bitlbee doesn't really support windows, except through cygwin. If you use cygwin the same installation methods in the README apply.

Answer 44 · 2017-05-02T07:06:26.000Z

I installed puple-facebook from the repo but I am still getting the error.

Answer 45 · 2017-05-02T11:43:58.000Z

@JR1994 This is bitlbee-facebook, not purple-facebook.

Answer 46 · 2017-05-02T17:39:16.000Z

I'm locking this thread since this is resolved.

If anyone has any issues please open a new issue instead.