Old buckets are never purged

Question

Old buckets are never purged

JensRantil opened this issue 11 years ago · 7 comments

I'm reading the code right now and notice that older buckets are never purged. Untouched buckets should probably have some kind of TTL. This is especially important for autogenerated counters. Creating this issue to make you aware of this. Please close if it's a non-issue.

mreiferson commented 11 years ago

oops

Answer 1 · 2013-10-08T15:10:48.000Z

For counters, this is probably a simple fix. I believe, a delete(counters, s) call could be added here.

Answer 2 · 2013-11-07T18:52:15.000Z

closed by #16

Answer 3 · 2013-11-07T22:05:57.000Z

This issue is not fully fixed. Only for counters.

Answer 4 · 2014-12-08T21:01:24.000Z

It might be possible to re-use the approach to purging counters in #41 to clean up gauges and other metrics too.

Happy to look into this if everyone's happy with #41 and it gets merged in to master.

Answer 5 · 2014-12-22T11:25:10.000Z

I submitted #51 to purge timers. Gauges now need to be persisted to allow for relative gauge operations so I think this is done.

Answer 6 · 2014-12-22T15:02:08.000Z

resolved in #51