bitlyfied/markdown-cv

Issue with end of p fields

Opened this issue · 1 comments

Hi. Just noticed that your script to parse the markdown and add your own divs leaves the

in the html code.

Your code should probably be someting like:

   html.gsub!(/^<p>\[(.*?)\/\]<\/p>/m, '<div class="\1"></div>')

instead of

    html.gsub!(/^<p>\[(.*?)\/\]/m, '<div class="\1"></div>')

Thanks for this utility !

Good spot!
If you feel like raising a pull request I'll merge it.
It's easy with tiny changes. You could just use the Github Edit button from here:
https://github.com/bitlyfied/markdown-cv/blob/master/Rakefile

By the way, if you plan to use it in real life, make sure you make some tests printing the output pdf.
I recently had a job interview. Some of the interviewers printed my CVs, and the layout was all wrong!
I suspect it was an issue with a missing font on Windows machines, but I haven't confirmed yet.

Let me know how it goes!