bitovi/github-actions-deploy-docker-to-ec2

Feature Request: Allow more dependency robustness / document dependency specification options

Crismon96 opened this issue · 2 comments

Our team has integrated your action as an integral part of our workflow now. Recently an upstream dependency (terraform AWS provider latest version) seemed to be broken somehow which produced errors.
In these kind of scenarios it would be desirable to be able to define dependency versions to always run with a working version.

Would it be possible to expose these dependency versions to configure that are currently defaulting to the latest version? If these options exist (I didnt fine them) could they be documented? Do you also think this is a realistic use case or that things shouldn't usually break.

@Crismon96 thanks for your input!, will be adding the option to specify the provider version in future releases.

Just to circle back here, the issue was that there was a bad version of the provider. since the underlying TF for this action (in commons) sets a fuzzy version, it picked up this broken provider version.

a new version of the aws provider has since been released, and it looks to have resoled the issue.

however, this ticket remains relevant because there might be similar issues in the future without such quick fixes, and there are likely other situations that would benefit from being able to specify the aws provider version.

Therefore, this ticket is now responsible for the implementation of a new action input that allows users to specify the aws provider version.

Note: the setting should have a readme section (or similar) to warn about possible pitfalls of adjusting the provider version without corresponding changes to the rest of the TF code (namely that one could easily pick a provider version that is incompatible with the underlying TF that exists in commons