Kraken Web Socket now available
Closed this issue · 35 comments
Kraken web socket is now available.
https://www.kraken.com/features/websocket-api
Is someone interested in developing a kraken interface? We can compensate for the development.
Thanks
Which features do you need?
- Ticker
- Trades
- Order book
- Account balances
- Account trades
- Account order updates
We need the public one:
Ticker
Trades
Order book
I've added the bounty label as a provisional advertisement
OK. Ticker and trades are simple. Order book is always a bit more complex. The API looks nice and clean though.
Thanks. The Order book is the one we need the most.
@badgerwithagun is ok for you to pick this up? Please if ok send me a message via email.
I don't think I have time right now, I'm afraid. I may do in a few weeks. In the meantime, hopefully someone else can pick it up.
Thanks @badgerwithagun.
Please if others are interested, contact me.
Hey @xpitrus I'm interested in Kraken Websocket. I need it soon so I may implement it.
thanks @AMA2018. Are you working on that? When do you think you can have it ready?
Hey @xpitrus. We need kraken websocket API in our business but the requirement has been delayed. We dont have the resources to work on that implementation yet. Anyone else able to do this?
@badgerwithagun some time now? reward still available!
@xpitrus: sorry, still too busy.
I am interested.. How do I take this issue?
Hello i am trying to implement the Kraken websocket. But because i don't understand how JsonNettyStreamingService works exactly i am don't know what method i need to implement. Can some just give me a hint about that? If some could implement only the kraken ping pong websocket subscription i would be grateful or point me somewhere that i can read about that. Thanks
Hello, i have just finished the orderbook of Kraken Stream. Although i haven't test it much, so if someone finds a bug please tell me in order to fix it.I am creating a pull Request. Here is my bitcoin address if anyone wants to buy me a beer and drink for his name. :)
3JujZaGj6yrUwpCfWqmWRFR9YiigCAE63c
Thanks
@makarid did you create pool request of kraken connector? I was going to create kraken connector by myself, but if you have one, I can help with additional features and testing.
Anyone wants to review it?
Sure, done. As normal, I'm reviewing it only for standards/consistency really. I'm not checking if the actual Kraken code actually works (I'll leave that to you lot who actually use it).
xpitrus, please close this issue
@pchertalev i have found some inconsistencies with the Kraken orderbook implementation. I am getting prices like 1.033E+4.Also ask prices do not update properly and there isn't any protection when bid is bigger than ask and reverse. Is it possible to fix at least the issue with the prices of 1.033E+4 like?
Lets close this issue guys?
@badgerwithagun @dozd
Guys is it possible to get a release with this fix included? Last release was some 4 months ago and there has been a lot of new stuff which we'd like to use... Pretty please?
Only @dozd can help with releases.
Doing it right now!
If you know @badgerwithagun what's needed for you to be able to make a release, give me a pm ;). I don't know if you can release a project into maven central with different GPG signature 🤔
It depends how you make the release. We use an account on OSS Sonatype Nexus to create staging repo and then promote it to maven cetral. IIRC it will accept any valid GPG key, but obviously you'd need to share the Sonatype account.
Whether it's worth the effort depends on knowm/XChange#3220.
It sounds like that's veering towards "merge them", in which case our target should be to get as many PRs cleared as we can, do a final release and then start submitting XChange PRs.
@badgerwithagun I'd support the merge for sure as long as the modularity is maintained (i.e. we only use streaming APIs, and we'd rather have minimal if any dependencies on REST parts)
@dpisklov - dependencies are impossible to avoid (xchange-stream-binance depends on xchange-binance, which depends on xchange-core - that's how they are designed) but in terms of calling REST APIs, yes, in general we try and avoid it except where absolutely necessary (e.g. getting initial snapshots for the order book stream on Binance).
I've specifically resisted letting the trade/account/balance streams get overcomplicated by features like self-correction, because it would mean too much complex use of multiple APIs to get right. I see no reason for that decision to change.
@badgerwithagun that's fair enough
There should be xchange-stream:4.4.0 in central. I will do the github rls later.