[kraken] Exchange orderbook timestamp parse incorrect!

Question

Opened this issue 5 years ago · 5 comments

The Kraken exchange orderbook timestamp is a seconds format since epoch. So need to multiply 1000. But this logic appear in two places:

One in:
info.bitrich.xchangestream.kraken.KrakenOrderBookUtils

private static long timestampToMs(String timestamp) {
return new BigDecimal(timestamp).multiply(new BigDecimal(1000)).longValue();
}

The other in:
org.knowm.xchange.kraken.KrakenAdapters.adaptOrders(...)

Answer 1 · 2019-11-27T11:35:15.000Z

@sudo168 Thank you for the issue. I have opend fix PR.

Answer 2 · 2019-12-06T16:27:40.000Z

I am good with this

Answer 3 · 2019-12-30T10:15:43.000Z

Have we fix this issue? If yes can we close it?

Answer 4 · 2020-01-08T23:02:14.000Z

I believe we can close it because PR is merged

Answer 5 · 2020-02-28T07:08:41.000Z

@badgerwithagun Bump for closing due to merged PR.