[kraken] Exchange orderbook timestamp parse incorrect!
Opened this issue · 5 comments
sudo168 commented
The Kraken exchange orderbook timestamp is a seconds format since epoch. So need to multiply 1000. But this logic appear in two places:
One in:
info.bitrich.xchangestream.kraken.KrakenOrderBookUtils
private static long timestampToMs(String timestamp) {
return new BigDecimal(timestamp).multiply(new BigDecimal(1000)).longValue();
}
The other in:
org.knowm.xchange.kraken.KrakenAdapters.adaptOrders(...)
pchertalev commented
@sudo168 Thank you for the issue. I have opend fix PR.
mdvx commented
I am good with this
makarid commented
Have we fix this issue? If yes can we close it?
pchertalev commented
I believe we can close it because PR is merged
TSavo commented
@badgerwithagun Bump for closing due to merged PR.