bitshares/bitshares-ui

Credit offer field max limits (field validation)

grctest opened this issue · 1 comments

grctest commented

Describe the bug
Entering a large enough number in several of the field will cause the following errors like: Uncaught Error ... cause: overflow

To Reproduce
Steps to reproduce the behavior:
Go to credit offer
Click on create or edit for credit offer modal
Enter too large a number for % rate (10000000000) and too large a number for minimum (a large number exceeding the borrow quantity)
Hit submit, see unhandled errors in console.

Expected behavior
Limit these fields, catch errors

Desktop (please complete the following information):

  • OS: windows
  • Browser: firefox
grctest commented

There's no warnings regarding applying an impossible fee like 5% on an asset with quantity 1 and precision 0 (an NFT) which could guarantee a default.

EBA's issued supply can grow/shrink based on deposits, so what may seem impossibly excessive could be resolved through an additional deposit.