bitwarden/jslib

"duo_web_sdk" dependency is used by "angular" package but the dependency is declared elsewhere

libertylocked opened this issue · 1 comments

Hi Bitwarden team,

I noticed that the two-factor.component.ts file imports 'duo_web_sdk', however this dependency is nowhere declared in angular or jslib package.

It is actually declared in the desktop package's package.json.

I'm not sure if it's intentional, but it seems like the dependency should be declared at where it is used, i.e. in jslib/angular/package.json.

I'm the maintainer of the Arch User Repository of bitwarden (https://aur.archlinux.org/packages/bitwarden/) and our current build script complains when two-factor.component.ts tries to import a dep that's not declared in the package. It seems to build fine if I patch jslib/angular/package.json tho.

Thanks

@libertylocked Thank you for your report and research. I've experienced a similar behaviour while setting up my dev environment. I'll have look into it, this evening.