bjerkio/oidc-react

Question: Why return value of onBeforeSignIn is limited to string?

savbace opened this issue · 3 comments

I'm curious why return type of onBeforeSignIn is limited to string?

onBeforeSignIn?: () => string;

Original SigninState.data has unknown type which basically means that we can put anything JSON-serializable in the state.

Thanks for answers!

Hello,

Thank you for posting this issue. You're referring to what oidc-client-ts are using; however, most of our concepts come from oidc-client-js.

The reason why it is set to string is basically because it's passed as state. See: #910

In not too deep into this anymore, so could you help me understand better what you use-cases are? Are you willing to open a PR? :)

@simenandre
Sorry, had no time to reply before. Posted simple PR outlining my intentions: #1021.