blaiszik/moment

Add auto-generated files to .gitignore

bdecost opened this issue · 2 comments

bdecost commented

from the PR guidelines:

Ensured that changes to auto-generated files have not been committed; in particular, *.html, *.csv, *.xml and *.json files.

We should help contributors out by adding these files to .gitignore, and using git commit --force or something in CI scripts for static site generation

blaiszik commented

So

  1. all template libraries, and even the central repo should be equipped with a .gitignore for those files (csv, xml, html, json, ...)
  2. the automated script should be adjusted to ignore the gitignore
blaiszik commented

Here is the implementation I drew inspiration from for this architecture. You can see how they ignore specific files here on line 23: https://github.com/alex/nyt-2020-election-scraper/blob/ba249bc68b533b160398dcf1d21641c2f80920ca/.github/workflows/pr.yml#L23

Full repo: https://github.com/alex/nyt-2020-election-scraper