blankname/vim-fish

Status

blankname opened this issue · 1 comments

blankname commented

Since @dag is less active with vim-fish I decided it would be a good learning experience to try maintaining a fork and merging some prs.

Merged:

  • dag#48
  • dag#25
    • Merged the ftplugin change and not the added support for fish -p output files (although I could probably be convinced to merge that too, just need to think about it a bit more).
  • dag#29

Not merged:

  • dag#46
    • Went with dag#46 as it was more comprehensive.
  • dag#47
    • Made a different change that covers any number of backslashes + quotes correctly.
  • dag#24
    • See comments on the merge of 25.
  • dag#43
    • This doesn't seem to be needed (the ftdetect autocommands don't seem to get doubled up).

Need to revisit:

  • dag#44
    • Originally I thought this was working without their change, but it turned out I had a plugin that was causing the desired behavior. I'll look into it again when I get the chance.

I've added a few other very minor miscellaneous changes as well (so feel free to browse the commit log).

Thanks @dag for creating vim-fish and all of the others for their contributions.

blankname commented

Instead of merging dag#44, I've added a commit that just drops '/' from the iskeyword definition.

I didn't remove the iskeyword definition entirely because I believe including '_' and '.' is still useful.

I also defined syntax iskeyword to include '/' so that the syntax patterns using \k are unaffected.