bleachbit/wishlist

Fetch all errors during NSIS compile

Opened this issue · 5 comments

It seems not all errors getting fetched during NSIS compile!
There were some language strings missing, this creates at least a warning, and it seems this didn't get recognized.

az0 commented

Are you refering to these lines in the log?

warning 9100: Generating version information for language "0000-Neutral" without standard key "FileDescription"
warning 9100: Generating version information for language "1033-English" without standard key "FileVersion"
warning 9100: Generating version information for language "1033-English" without standard key "LegalCopyright"

No, not those, but those we should fix also, if we don check in the new installers... but as I think you will land the PR soon... but I can fix it (make a PR) if you like...

Sorry, didn't made a SS of those I meant, just fixed it... but let me have a look on the old AppVoyer logs...

Seems warnings are ATM not show... but I make a small PR that they get shown! Then you can try to fetch them...

Compiling looks IMHO better with bleachbit/bleachbit#693...

2019-11-12 07_33_50-bleachbit 3 0 1 1372 - AppVeyor

2019-11-12 07_35_26-bleachbit 3 0 1 1372 - AppVeyor

...there are still warnings/errors, but I can dig later into them...