blewisio/vocabulary

isNullOrEmpty() issue

Opened this issue · 0 comments

Hey Blake,

First off, nice repo you have here. I just wanted to reach out because I saw a slight issue with your isNullOrEmpty(value) function. If an array that has a null element(s) is passed into it, false is returned. So I believe adding another isArrayNull() helper function is needed. For example,
Array.prototype.isNull = function (){ return this.join().replace(/,/g,'').length === 0; };
Then adding if(Array.isArray(value) && value.isNull()){return true;} within isNullOrEmpty(value). Let me know if you want me to open a PR.

I am also in Austin for the week and saw that you work at uShip and wanted to see if you all are looking for a full stack (or FE) developer? I am currently looking for a job/internship for the summer. My email is kenny-song@uiowa.edu. Would love to talk soon!

Cheers,

Kenny Song