blib-la/runpod-worker-comfy

model / custom node provisioning script

Dekita opened this issue · 5 comments

Dekita commented

If we could somehow define a 'provisioning' type script that allows for custom models etc to be added to the container image that'd be great! I seem to be having severe issues when trying to manually re-create the image locally :(

Perhaps something similar to the ai-dock runpod images (which is set via an env variable pointing to a github url where the prov script is, see the docker-compose for the project):
https://github.com/ai-dock/comfyui/tree/main/config/provisioning

edit: not really sure if this is possible for during the image build step, might still need to rebuild the image for custom models, but it'd be nice! :D

TimPietrusky commented

@Dekita It might be a good idea to introduce the network-volume for this case and connect this with Comfy, so that you can put any model you want into the volume and then those will be used instead of the ones that come with the image. See #1

How does this sound?

Dekita commented

yea that sounds like it could work fine. end goal is just to be able to use custom models/loras/workflow nodes etc :)

TimPietrusky commented

@Dekita then I will continue the work in #1 and if it works fine, we can close this one, ok?

Dekita commented

yea thats fair, a network volume would likely help a lot for keeping the image size small too :)

TimPietrusky commented

@Dekita thank you so much for all your input!

  • We decided to not provide a custom provisioning script, but keep it simple.
  • The network-volume was implemented with 2.2.0.