My fix to avoid receiving Timer-event on CudaText closing, and the crash

Question

My fix to avoid receiving Timer-event on CudaText closing, and the crash

Alexey-T opened this issue 3 years ago · 6 comments

Alexey-T/CudaText@87e2bff

This is a patch in CudaText's copy of UniqInstance. You see that I moved Timer object to class fields, and I disable this timer in Destroy.
crash was visible when I debugged the CudaText.

Answer 1 · 2021-07-17T18:57:19.000Z

Please open a Pull Request: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Answer 2 · 2021-07-17T19:00:55.000Z

sorry, for PR I would need to get your code and test it. no time.

Answer 3 · 2021-07-17T20:42:21.000Z

Sorry, this is how collaborating in Github works.

Answer 4 · 2021-07-17T21:03:52.000Z

no, it don't work always this way. I sometimes get patches via email.

if you don't want to improve the upstream code, do it as you wish.

Answer 5 · 2021-07-18T00:14:40.000Z

Opening Pull Requests is pretty easy, i've done literally hundreds of times to different repositories.

I'm just asking to do what i do to other projects and what is default in github community

Answer 6 · 2021-07-18T08:53:19.000Z

it's easy if I can tests the resulting pascal file, how it's compiled, how it works, but I am busy.