bling/evil-visualstar

Make this a minor-mode?

Closed this issue · 2 comments

expez commented

It's considered an anti-pattern to have a package do stuff as part of being required. It would be nice if this was turned into a minor-mode so its functionality could be toggled. The only way to undo the effects of evil-visualstar now is to manually rebind * and #.

bling commented

thanks for the pointer. unfortunately, making this change would break it for everyone who installed it from MELPA. and since there's really no easy way to notify people of breaking changes, i'm a bit hesitant.

the only sensible thing i can do i think is the introduce the minor mode but still turn it on by default upon requiring.

expez commented

You're still a version 0.0.1 so this seems like a good time to make such a breaking change :)

Everyone using MELPA is expecting some breakage every now and then, or they'd use MELPA-stable or marmelade.